Redfish: Implements Redfish Assembly Health #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Hi @SunnySrivastava1984 @jinuthomas, I don't have assemblies. Can you help me test this commit? |
gtmills
reviewed
Dec 15, 2021
|
jenkins run test please |
|
@ChicagoDuan Can this get pushed upstream? |
gtmills
approved these changes
Jan 12, 2022
Look for the OperationalStatus to set the Assembly Health. If the OperationalStatus is false, then set the Health to "Critical" If the OperationalStatus is true, then the Health is "OK" Signed-off-by: Chicago Duan <duanzhijia01@inspur.com>
Hi @gtmills , I pushed it to the gerrit : https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/50317, but CI failed. It seems that the parent commit needs rebase. Hi @SunnySrivastava1984 , Can you rebase this commit : Inventory properties via Assembly schema on bmcweb https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/39574/41 . Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look for the OperationalStatus to set the Assembly Health.
If the OperationalStatus is false, then set the Health to "Critical"
If the OperationalStatus is true, then the Health is "OK"
Upstream:
https://gerrit.openbmc.org/c/openbmc/bmcweb/+/50317
Signed-off-by: Chicago Duan duanzhijia01@inspur.com