1050: Move changeLogo.sh to /usr/bin #284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
lxwinspur
pushed a commit
to lxwinspur/openbmc
that referenced
this pull request
Jun 12, 2023
Myung Bae (2):
GET PATCH userGroups Information ("AccountTypes") (ibm-openbmc#270)(ibm-openbmc#284) (#614)
Return forbidden return code for RestrictedRole operations (#619)
Change-Id: I5261a6474d17f47cc47ec1293bd219e29900cbc0
|
add to approvelist |
|
544618 is the internal defect |
|
We got an internal failure building this: Please look at this and be sure to add a "Tested:" to the commit msg indicating what testing was done (basically verify it compiles and script is in expected location) |
anoo1
requested changes
Jun 20, 2023
Fixes ibm-openbmc/dev#3629 Tested: Built webui-vue successfully ls tmp/work/p10bmc-openbmc-linux-gnueabi/obmc-phosphor-image/1.0-r0/rootfs/lib/systemd/system | grep change-logo.service change-logo.service ls tmp/work/p10bmc-openbmc-linux-gnueabi/obmc-phosphor-image/1.0-r0/rootfs/usr/bin | grep changeLogo.sh changeLogo.sh Signed-off-by: George Liu <liuxiwei@inspur.com>
lxwinspur
force-pushed
the
1050.00_changeLog
branch
from
811e923
to
8dafdb0
Compare
anoo1
approved these changes
Jun 21, 2023
geissonator
approved these changes
Jun 21, 2023
|
@lxwinspur Could you push this changeLogo stuff to upstream meta-ibm ? Lower priority but would be good to not have to carry.. |
|
Reed pulled this into our GitHub Enterprise and merged it. Closing this and the issue. Thanks for the help here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ibm-openbmc/dev#3629