Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login screen modifications #40

Closed

Conversation

LuluTHSu
Copy link
Contributor

The image displayed on the login screen is modified to one, and
fine-tuned the frame size.

Signed-off-by: Ben Pai Ben_Pai@wistron.com
Signed-off-by: LuluTHSu Lulu_Su@wistron.com

The image displayed on the login screen is modified to one, and
fine-tuned the frame size.

Signed-off-by: Ben Pai <Ben_Pai@wistron.com>
Signed-off-by: LuluTHSu <Lulu_Su@wistron.com>
@@ -19,17 +19,9 @@
left: 0;
margin-left: 0;
}
.login__logo {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still look okay with the IBM logo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original login screen

image

Use this modified login screen

  1. No keyword in VPD
    image

  2. Keyword in VPD
    image

Copy link
Contributor

@gtmills gtmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't use the OpenBMC logo.
I really don't think we should use a screenshot (of the 2 logos and text) as the new image.

@derick-montague
Copy link
Contributor

We can't use the OpenBMC logo.
I really don't think we should use a screenshot (of the 2 logos and text) as the new image.

This is our design plan for 1020. Not sure if we use the Power logo or not. If not, it's just not shown.
image

@LuluTHSu
Copy link
Contributor Author

LuluTHSu commented Jul 17, 2021

We can't use the OpenBMC logo.
I really don't think we should use a screenshot (of the 2 logos and text) as the new image.

No problem, as long as you tell us the final layout format, we will cover the logo with a blank logo.

The methods used in these two samples are all completed by the systemd service we added, so phosphor-webui doesn't need to be changed, we only need to re-push the openbmc patch.

Sample 1
image

Sample 2
image

@LuluTHSu
Copy link
Contributor Author

IBM made the final decision after internal discussions.
We will use the "sample 2" to be the final layout.
So close this comment, only modify the openbmc patch and resubmit. thank.

When there are keywords in VPD
Logo on the login screen
image

Logo on the screen after login
image

@LuluTHSu LuluTHSu closed this Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants