-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Login screen modifications #40
Conversation
The image displayed on the login screen is modified to one, and fine-tuned the frame size. Signed-off-by: Ben Pai <Ben_Pai@wistron.com> Signed-off-by: LuluTHSu <Lulu_Su@wistron.com>
@@ -19,17 +19,9 @@ | |||
left: 0; | |||
margin-left: 0; | |||
} | |||
.login__logo { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this still look okay with the IBM logo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't use the OpenBMC logo.
I really don't think we should use a screenshot (of the 2 logos and text) as the new image.
No problem, as long as you tell us the final layout format, we will cover the logo with a blank logo. The methods used in these two samples are all completed by the systemd service we added, so phosphor-webui doesn't need to be changed, we only need to re-push the openbmc patch. |
IBM made the final decision after internal discussions. |
The image displayed on the login screen is modified to one, and
fine-tuned the frame size.
Signed-off-by: Ben Pai Ben_Pai@wistron.com
Signed-off-by: LuluTHSu Lulu_Su@wistron.com