Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with libxml2-2.12.0 #160

Closed
wants to merge 1 commit into from

Conversation

yselkowitz
Copy link
Contributor

https://gitlab.gnome.org/GNOME/libxml2/-/releases/v2.12.0

"Several cyclic dependencies in public header files were fixed. As a result, certain headers won't include other headers as before."

Compare build results:

unpatched: https://koji.fedoraproject.org/koji/taskinfo?taskID=109774742
patched: https://koji.fedoraproject.org/koji/taskinfo?taskID=110257790

/cc @sharkcz

Copy link
Contributor

@ifranzki ifranzki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sharkcz
Copy link
Contributor

sharkcz commented Dec 13, 2023

LGTM, thanks @yselkowitz

@hoeppnerj
Copy link
Contributor

@yselkowitz thanks for the contribution.
Can you please add your Sign-Off and change the subject of the commit to libkmipclient: Fix build with libxml2-2.12.0, thanks!

https://gitlab.gnome.org/GNOME/libxml2/-/releases/v2.12.0

"Several cyclic dependencies in public header files were fixed. As a result,
certain headers won't include other headers as before."

Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
@hoeppnerj
Copy link
Contributor

Thanks for the update. Pulled and integrated.

@hoeppnerj hoeppnerj closed this in 6274294 Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants