-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add DependencyMetric and NpmScope #53
Merged
jdharvey-ibm
merged 26 commits into
main
from
51-npm-scope-generate-capturable-metrics-from-dependencies
Sep 12, 2023
Merged
feat: add DependencyMetric and NpmScope #53
jdharvey-ibm
merged 26 commits into
main
from
51-npm-scope-generate-capturable-metrics-from-dependencies
Sep 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into 51-npm-scope-generate-capturable-metrics-from-dependencies
… into 51-npm-scope-generate-capturable-metrics-from-dependencies
…ies' of github.com:carbon-design-system/telemetrics-js into 51-npm-scope-generate-capturable-metrics-from-dependencies
Co-authored-by: Francine Lucca <francinelucca@users.noreply.github.com>
… into 51-npm-scope-generate-capturable-metrics-from-dependencies
Co-authored-by: Joe Harvey <jdharvey-ibm@users.noreply.github.com>
Co-authored-by: Joe Harvey <jdharvey-ibm@users.noreply.github.com>
- also update eslint vitest config to only run on test files. - update unit tests as per refactors
Co-authored-by: Joe Harvey <jdharvey-ibm@users.noreply.github.com>
- refactor some unit tests to use snapshots
jdharvey-ibm
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51
Closes #37
Changelog
New
DependencyMetric
class and Unit testsNpmScope
class and Unit testsgetPackageDependencies
util and Unit tests. usesexec
to get dependencies and devDependencies from package.json depending on thetype
paramScope
Changed
Scope
class'capture
method to log to logger instead (this is temporary as this method is not fully implemented yet)Testing / reviewing
await new NpmScope(new Logger('./log.log')).run()
to the bottom of the npm-scope.ts file, build the project and thennode dist/main/scopes/npm/npm-scope.js
and you should see the logs for each of the current dependencies and devDependencies in the project logged to the new log fileTODO
getInstallingPackages
function and NpmScoperun
with Joe