Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove invoker attributes from jsx scope #194

Merged
merged 2 commits into from
Mar 8, 2024
Merged

fix: remove invoker attributes from jsx scope #194

merged 2 commits into from
Mar 8, 2024

Conversation

francinelucca
Copy link
Contributor

Related #ibm-telemetry/telemetry-attributes-js#8

Removes invoker.xxx attributes from jsx scope

Changelog

Removed

  • Removes elementInvokers from JsxElementAccumulator, no longer needed
  • Removes all logic pertaining to computing and sending invoker data from JsxScope to ElementMetric
  • Removes invoker.xxx attributes from ElementMetric
  • Removes all mention of invokers from unit/e2e test

Testing / reviewing

All unit/e2e tests should pass

@francinelucca francinelucca requested a review from a team as a code owner February 28, 2024 22:17
@francinelucca
Copy link
Contributor Author

@jdharvey-ibm does anything need to happen on the collector side of things to accept metrics without those fields?

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@francinelucca francinelucca merged commit 6c2d122 into main Mar 8, 2024
6 checks passed
@francinelucca francinelucca deleted the fix/remove-invoker-attributes-from-jsx-element-metrics branch March 8, 2024 21:09
@telemmy telemmy bot mentioned this pull request Mar 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdharvey-ibm jdharvey-ibm jdharvey-ibm approved these changes

Assignees
No one assigned
Labels
status: ready for review 👀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@francinelucca @jdharvey-ibm