fix: do not emit metrics if empty #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdharvey-ibm
approved these changes
Apr 11, 2024
|
jdharvey-ibm
approved these changes
Apr 11, 2024
francinelucca
deleted the
185-do-not-transmit-any-data-if-no-metrics-are-collected
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #185
Checks
ResourceMetricsobject before emitting metrics and returns early (i.e., does not emit) if all scopes' metrics are empty.Changelog
New
emitMetricsto test new edge casesChanged
IbmTelemetry:emitMetrics: do not emit any data if there isn't at least 1 metric.IbmTelemetry'semitMetricsfunction public (so that we can test it)Testing / reviewing
Unit tests should pass