Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add named args in readme file #34

Merged
merged 5 commits into from Oct 10, 2017
Merged

Add named args in readme file #34

merged 5 commits into from Oct 10, 2017

Conversation

bassel-zeidan
Copy link
Collaborator

No description provided.

@bassel-zeidan
Copy link
Collaborator Author

@gadamc could you please take a look at this

gadamc
gadamc requested changes Oct 10, 2017
View reviewed changes
Copy link
Collaborator

@gadamc gadamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'd like to move toward the 'configuration_name' being required. So that we don't have to change this again later, please just add the named parameters for cos_type and auth_method.

@gadamc gadamc merged commit 56c318c into master Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadamc gadamc gadamc requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bassel-zeidan @gadamc