Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the static datasource option the default #1694

Closed
lmsurpre opened this issue Nov 11, 2020 · 1 comment
Closed

Make the static datasource option the default #1694

lmsurpre opened this issue Nov 11, 2020 · 1 comment
Assignees
@lmsurpre
Labels
documentation Improvements or additions to documentation P1 Priority 1 - Must Have
Milestone
Sprint 2021-03

Comments

@lmsurpre
Copy link
Member

Is your feature request related to a problem? Please describe.
In #916 we introduced a new static datasource option. Now I'd like that to be the default.
This will enable us to follow OpenLiberty docker image recommendations (e.g. see #923), use the newer maven-based liberty dev mode support, and potentially even run on other application servers.

Describe the solution you'd like
The default IBM FHIR Server image should use a static datasource approach which leverages configDropins to easilly add an remove tenant-based datasource definitions.

Describe alternatives you've considered
Keep using our FHIRProxyDatasource as the default.
@lmsurpre lmsurpre mentioned this issue Nov 11, 2020
Closed
@kmbarton423 kmbarton423 added the documentation Improvements or additions to documentation label Nov 16, 2020
@lmsurpre lmsurpre added this to the Sprint 2021-02 milestone Jan 25, 2021
@lmsurpre lmsurpre self-assigned this Feb 10, 2021
@lmsurpre lmsurpre added the P1 Priority 1 - Must Have label Feb 23, 2021
@lmsurpre lmsurpre assigned tbieste and unassigned tbieste Feb 23, 2021
lmsurpre added a commit that referenced this issue Feb 25, 2021
@lmsurpre
issue #1694 - make liberty datasources the default
9d21265 
1. rework the user's guide
2. remove the fhirSharedLib

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Feb 25, 2021
@lmsurpre
issue #1694 - make liberty datasources the default
ce24c3d 
1. rework the user's guide
2. remove the fhirSharedLib

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Feb 25, 2021
@lmsurpre
issue #1694 - make liberty datasources the default
3c722d1 
1. rework the user's guide
2. remove the fhirSharedLib

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Feb 25, 2021
@lmsurpre
issue #1694 - make liberty datasources the default
5e25a41 
1. rework the user's guide
2. remove the fhirSharedLib

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Feb 25, 2021
@lmsurpre
issue #1694 - make liberty datasources the default
98e062f 
1. rework the user's guide
2. remove the fhir jars from the fhirSharedLib and move the definition
from server.xml into the corresponding datasource dropinConfigs (this
way we can only include the drivers that will actually be used)
3. stop excluding fhir-core and fhir-config from our webapps since
they're no longer in the shared lib
4. other minor dependency tweaking to avoid packaging derby with our
webapps

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Feb 25, 2021
@lmsurpre
issue #1694 - make liberty datasources the default
16554f8 
1. rework the user's guide
2. remove the fhir jars from the fhirSharedLib and move the definition
from server.xml into the corresponding datasource dropinConfigs (this
way we can only include the drivers that will actually be used)
3. stop excluding fhir-core and fhir-config from our webapps since
they're no longer in the shared lib
4. other minor dependency tweaking to avoid packaging derby with our
webapps

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Feb 26, 2021
@lmsurpre
issue #1694 - make liberty datasources the default
324493c 
1. rework the user's guide
2. remove the fhir jars from the fhirSharedLib and move the definition
from server.xml into the corresponding datasource dropinConfigs (this
way we can only include the drivers that will actually be used)
3. stop excluding fhir-core and fhir-config from our webapps since
they're no longer in the shared lib
4. other minor dependency tweaking to avoid packaging derby with our
webapps

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Feb 28, 2021
@lmsurpre
issue #1694 - make liberty datasources the default
6963775 
1. rework the user's guide
2. remove the fhir jars from the fhirSharedLib and move the definition
from server.xml into the corresponding datasource dropinConfigs (this
way we can only include the drivers that will actually be used)
3. stop excluding fhir-core and fhir-config from our webapps since
they're no longer in the shared lib
4. other minor dependency tweaking to avoid packaging derby with our
webapps

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Mar 1, 2021
@lmsurpre
issue #1694 - rework dependency tree
16d0071 
Remove exclusions while still avoiding packaging the db drivers into the
webapp

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Mar 2, 2021
@lmsurpre
issue #1694 - remove the fhir-persistence-proxy more completely
b2377fd 
1. Remove references to enabling the proxy datasource from the user's
guide
2. Remove the datasource-proxy.xml configDropin example
3. Stop packaging fhir-peristence-jdbc (and its dependencies) in the
shared resources lib
4. Mark the enabledProxyDatasource and jdbc-level dataSourceJndiName as
deprecated

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Mar 2, 2021
@lmsurpre
issue #1694 - remove the fhir-persistence-proxy more completely
56520e3 
1. Remove references to enabling the proxy datasource from the user's
guide
2. Remove the datasource-proxy.xml configDropin example
3. Stop packaging fhir-peristence-jdbc (and its dependencies) in the
shared resources lib
4. Mark the enabledProxyDatasource and jdbc-level dataSourceJndiName as
deprecated

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
@tbieste tbieste mentioned this issue Mar 3, 2021
Open
@kmbarton423
Copy link
Contributor

Attempted scenarios where fhir-server-config.json was not properly migrated away from fhirProxyDatasource.
Result: "FHIRPersistenceException: Unexpected exception while creating JDBC persistence layer: 'Failure acquiring datasource'"

Sample log messages:
[ERROR ] Failure acquiring datasource: jdbc/fhirProxyDataSource
CWWKN0008E: An object could not be obtained for name jdbc/fhirProxyDataSource.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmsurpre lmsurpre

Labels
documentation Improvements or additions to documentation P1 Priority 1 - Must Have
Projects
None yet
Milestone
Sprint 2021-03
Development

No branches or pull requests
3 participants
@lmsurpre @tbieste @kmbarton423