Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select by edge and not by edge name #51

Closed
TathagataChakraborti opened this issue Feb 7, 2024 · 1 comment · Fixed by #49
Closed

Select by edge and not by edge name #51

TathagataChakraborti opened this issue Feb 7, 2024 · 1 comment · Fixed by #49
Assignees
Labels
bug Something isn't working enhancement New feature or request feature New Feature

Comments

@TathagataChakraborti
Copy link
Member

🐞 Bug

Currently, a disambiguation choice is registered by edge name and not by edge ID which while the algorithms in the backend follow ID. This needs to be consistent.

💡 Feature

The implication here is that when making a selection the user is not only selecting membership but also choice. It's debatable which one is the "right" thing to do. The proposal is to put this in as a mode users can select.

For SELECT mode, this does not make much difference visually. For BUILD forward and backward, the ordered choice will fix the second issue in #41 while for unordered choice the color coding scheme needs to update to only show disambiguating choices in green.

👀 Note that the two options will have an impact on an ordered versus un-ordered plan generation scheme. This needs to be investigated further during the simulations.

@TathagataChakraborti TathagataChakraborti added bug Something isn't working enhancement New feature or request feature New Feature labels Feb 7, 2024
@TathagataChakraborti TathagataChakraborti self-assigned this Feb 7, 2024
@TathagataChakraborti
Copy link
Member Author

Implemented feature: it is possible to select edges either by name or by edge.

This makes the selection process not agnostic to the order of selection and the undo interaction becomes unstable. As a result, undo is now only available on name-based interaction and a global reset of all selections is available for all interactions.

Furthermore, this makes switching between views unstable. If edge-based selection is turned on, we now reset the current interaction.

@TathagataChakraborti TathagataChakraborti linked a pull request Feb 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request feature New Feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant