Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

MAXModelWrapper: remove sbtractmethod annotations from optional methods #27

Closed
ptitzler opened this issue May 28, 2019 · 2 comments
Closed

MAXModelWrapper: remove sbtractmethod annotations from optional methods #27

ptitzler opened this issue May 28, 2019 · 2 comments
Assignees
@djalova
Labels
bug Something isn't working

Comments

@ptitzler
Copy link

PR #21 enforces the @abstractmethod annotations which are defined for the following methods:

  • __init__
  • _pre_process
  • _post_process
  • _predict

As a result every model that inherits from MAXModelWrapper must implement these methods, even if they don't have any custom code.

The problematic code was published as version 1.1.2.
@ptitzler ptitzler added the bug Something isn't working label May 28, 2019
@ptitzler
Copy link
Author

To avoid having to implement those methods, only _predict should be an abstract method.

@ptitzler ptitzler mentioned this issue May 29, 2019
Merged
@ptitzler
Copy link
Author

Addressed by #28

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@djalova djalova

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@djalova @ptitzler