Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turning on debug logging prints the password in connect string. #563

Closed
jajuanMitchell opened this issue Aug 12, 2019 · 4 comments
Closed

Turning on debug logging prints the password in connect string. #563

jajuanMitchell opened this issue Aug 12, 2019 · 4 comments

Comments

@jajuanMitchell
Copy link

Debug logging should not print the password in the log file. Currently the password is part of the connect string and is logged which is a security issue.
@bimalkjha
Copy link
Member

@jajuanMitchell Can you share the part of the log file where you see connection string is getting logged? I think it should be in case of pooled connection, where pool contents is getting dumped. pool stores all connection objects of same connection string in one array with connection string. Also, debug mode is enabled by the user who already know the password. If user is sharing the log with others, should remove passwd from log file and then share. Thanks.

@jajuanMitchell
Copy link
Author

@jajuanMitchell Can you share the part of the log file where you see connection string is getting logged? I think it should be in case of pooled connection, where pool contents is getting dumped. pool stores all connection objects of same connection string in one array with connection string. Also, debug mode is enabled by the user who already know the password. If user is sharing the log with others, should remove passwd from log file and then share. Thanks.

logs

@bimalkjha
Copy link
Member

@jajuanMitchell Thanks. Only option is to remove this log from code and above log will not get dumped when debug is enabled. We'll look into it.

bimalkjha added a commit that referenced this issue Aug 16, 2019
@bimalkjha
fix for issue #563
526c88b
@bimalkjha
Copy link
Member

pushed fix of this issue as latest commit in master.

bimalkjha added a commit that referenced this issue Aug 19, 2019
@bimalkjha
2.6.0
9085716 
 * update windows binary in build.zip file (Priyanka Manoharan)
 * fix: use nan converters (Bimal Jha)
 * fix for issue #563 (Bimal Jha)
 * fix memory leak issue #452 (Bimal Jha)
 * Added section on configuration keywords available (#560) (Dariusz Danielewski)
 * support for executeFile Api (#558) (PriyankaManoharan04)
 * Node 12.x Support (#564) (Bimal Kumar Jha)
 * Add vscode binary for 4.2.5 (Bimal Jha)
 * electron 4.2.5 version is supported (#556) (Akhil Ravuri)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bimalkjha @jajuanMitchell