Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractAdapter fixes for Rails 5 #88

Closed
wants to merge 1 commit into from

Conversation

calh
Copy link

@calh calh commented Jun 27, 2019

Starting in rails 5.0, the initializer for AbstractAdapter changed

rails/rails@8c53b20

This makes the ibm_db gem compatible with the latest octopus sharding gem version. The line:

super(@connection, logger, config)

fixes the rails 5 AbstractAdapter change, and the line

@config = config

backpatches the issue for rails 3 and 4, so that the octopus gem and ibm_db will still work with older versions of rails.

Starting in rails 5.0, the initializer for AbstractAdapter changed

rails/rails@8c53b20
@akhilravuri1
Copy link
Contributor

Thanks for raising the pull request. In the latest release we have added support for the rails 6 version also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants