Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider revisions to fn_qradar #52

Open
jjfallete opened this issue Apr 13, 2020 · 0 comments
Open

Consider revisions to fn_qradar #52

jjfallete opened this issue Apr 13, 2020 · 0 comments

Comments

@jjfallete
Copy link

Description

Revisions would improve how the qradar_search function works.

Current implementation issues:
Implementation is clunky in the use of generic "qradar_query_param" parameters as opposed to managing them in the post-processor and passing complete AQL to the function. Implementation is more abstract than necessary, and has associated bugs in search waiting as a result. Implementation does not have robust error handling and reporting. Implementation does not cancel searches on workflow termination. Implementation does not cancel searches on query timeout. Implementation does not pass events in clean dictionary structure for post-processor use in dynamic table creation. Implementation does not regard file upload limit for Resilient attachments.

Please see changes here: https://github.com/jjfallete/resilient/tree/master/functions/qradar
Tests and customize.py will need to be recreated.

Describe How to Reproduce

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant