Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storing Resilient Args in Registry for Windows Service Generation #27

Merged

Conversation

lmahoney1
Copy link
Contributor

Description

Storing arguments passed into the --res-circuits-args option for command resilient-circuits.exe service ... install in the Windows registry.

This post gave me the insight on how to do this.

Motivation and Context

Allows arguments to be passed to resilient circuits when it's being ran as a windows service - e.g. you can run the service with a custom app.config location.

Was looking into this because we have a couple of integrations running on a Windows server that we want running in virtual environments / their own integration server.

How Has This Been Tested?

I have generated windows services via command resilient-circuits.exe service --res-circuits-args "--config-file C:\\Users\\USER\\Path\\To\\app.config" install and have verified the proper app.config file was loaded by the resilient circuits started through a Windows Service

Checklist:

  • I have added a Signed-off-by
  • Either no new documentation is required by this change, OR I added new documentation
  • [] Either no new tests are required by this change, OR I added new tests
  • [] I have run pep8 and pylint. I have cleaned up all valid errors and warnings in code I have added or modified. These tools may generate false positives. Don't be worried about ignoring some errors or warnings. The goal is clean, consistent, and readable code.

Signed-off-by: Liam Mahoney

@bobleckelibm
Copy link
Collaborator

Hi @lmahoney1 — this looks promising. As you might know, we've shifted most of our focus to supporting app host enabled apps. In that process, there are some things integration server specific that have fallen off, especially windows specific features. While we still do support this, we don't always have the bandwidth to test. With that in mind, we'd like to consider this change. I'd like to set up a time with you where we could go over the changes on a call to better get a handle on the context and see it in action. Would that be possible for you? You can reach out to me at bo.bleckel@ibm.com and we can start scheduling something there. Thanks!

@bobleckelibm bobleckelibm changed the base branch from main to release/v50.1.x September 7, 2023 13:59
@bobleckelibm bobleckelibm merged commit 326ac11 into ibmresilient:release/v50.1.x Sep 7, 2023
@bobleckelibm
Copy link
Collaborator

Now in internal QA

@bobleckelibm
Copy link
Collaborator

Release to PyPi on Oct 5 as resilient-circuits v50.1.262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants