Set a default thread name for java.util.TimerThread #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithc-ca
reviewed
Aug 9, 2023
|
Please explain how this helps; see eclipse-openj9/openj9#11930 (comment). |
|
Added a new comment eclipse-openj9/openj9#11930 (comment) |
pshipton
changed the title
|
Updated the commit and PR with the details as well. |
|
The commit should mention |
Issue eclipse-openj9/openj9#11930 The name isn't set in the TimerThread constructor, it calls Thread.genThreadName() which consumes the "Thread-0" name. This causes the test to fail because it expects this name. This could have an impact on / confuse users which expect consistent thread names. Depending on the timing of the Attach API AttachHandler / FilelockTimer creation, an application can get different default thread names from run to run. Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
|
Updated it. |
keithc-ca
approved these changes
Aug 9, 2023
|
Jenkins test sanity amac jdknext |
pshipton
added a commit
to pshipton/openj9-openjdk-jdk21
that referenced
this pull request
Aug 9, 2023
Issue eclipse-openj9/openj9#11930 The name isn't set in the TimerThread constructor, it calls Thread.genThreadName() which consumes the "Thread-0" name. This causes the test to fail because it expects this name. This could have an impact on / confuse users which expect consistent thread names. Depending on the timing of the Attach API AttachHandler / FilelockTimer creation, an application can get different default thread names from run to run. Backport of ibmruntimes/openj9-openjdk-jdk#640 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton
added a commit
to pshipton/openj9-openjdk-jdk17
that referenced
this pull request
Aug 9, 2023
Issue eclipse-openj9/openj9#11930 The name isn't set in the TimerThread constructor, it calls Thread.newName() which consumes the "Thread-0" name. This causes the test to fail because it expects this name. This could have an impact on / confuse users which expect consistent thread names. Depending on the timing of the Attach API AttachHandler / FilelockTimer creation, an application can get different default thread names from run to run. Backport of ibmruntimes/openj9-openjdk-jdk#640 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton
added a commit
to pshipton/openj9-openjdk-jdk11
that referenced
this pull request
Aug 9, 2023
Issue eclipse-openj9/openj9#11930 The name isn't set in the TimerThread constructor, it calls Thread.newName() which consumes the "Thread-0" name. This causes the test to fail because it expects this name. This could have an impact on / confuse users which expect consistent thread names. Depending on the timing of the Attach API AttachHandler / FilelockTimer creation, an application can get different default thread names from run to run. Backport of ibmruntimes/openj9-openjdk-jdk#640 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton
added a commit
to pshipton/openj9-openjdk-jdk21
that referenced
this pull request
Aug 10, 2023
Issue eclipse-openj9/openj9#11930 The name isn't set in the TimerThread constructor, it calls Thread.genThreadName() which consumes the "Thread-0" name. This causes the test to fail because it expects this name. This could have an impact on / confuse users which expect consistent thread names. Depending on the timing of the Attach API AttachHandler / FilelockTimer creation, an application can get different default thread names from run to run. Backport of ibmruntimes/openj9-openjdk-jdk#640 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton
added a commit
to pshipton/openj9-openjdk-jdk17
that referenced
this pull request
Aug 10, 2023
Issue eclipse-openj9/openj9#11930 The name isn't set in the TimerThread constructor, it calls Thread.newName() which consumes the "Thread-0" name. This causes the test to fail because it expects this name. This could have an impact on / confuse users which expect consistent thread names. Depending on the timing of the Attach API AttachHandler / FilelockTimer creation, an application can get different default thread names from run to run. Backport of ibmruntimes/openj9-openjdk-jdk#640 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton
added a commit
to pshipton/openj9-openjdk-jdk11
that referenced
this pull request
Aug 10, 2023
Issue eclipse-openj9/openj9#11930 The name isn't set in the TimerThread constructor, it calls Thread.newName() which consumes the "Thread-0" name. This causes the test to fail because it expects this name. This could have an impact on / confuse users which expect consistent thread names. Depending on the timing of the Attach API AttachHandler / FilelockTimer creation, an application can get different default thread names from run to run. Backport of ibmruntimes/openj9-openjdk-jdk#640 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton
added a commit
to pshipton/openj9-openjdk-jdk8
that referenced
this pull request
Aug 10, 2023
Issue eclipse-openj9/openj9#11930 The name isn't set in the TimerThread constructor, it calls Thread.newName() which consumes the "Thread-0" name. This causes the test to fail because it expects this name. This could have an impact on / confuse users which expect consistent thread names. Depending on the timing of the Attach API AttachHandler / FilelockTimer creation, an application can get different default thread names from run to run. Backport of ibmruntimes/openj9-openjdk-jdk#640 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue eclipse-openj9/openj9#11930
The name isn't set in the TimerThread constructor, it calls Thread.genThreadName() which consumes the "Thread-0" name. This causes the test to fail because it expects this name. This could have an impact on / confuse users which expect consistent thread names. Depending on the timing of the Attach API AttachHandler / FilelockTimer creation, an application can get different default thread names from run to run.