-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include vcruntime140_1.dll when compiling with VS2019 #574
Conversation
jenkins compile win jdk11 |
4fb7b78
to
0765fa0
Compare
jenkins compile win jdk11 |
Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
0765fa0
to
4744d6b
Compare
jenkins compile win jdk11 |
|
The OpenJDK changes backported were made in 2020, so I used that date. |
@keithc-ca do you have an opinion on what copyright date to use? |
I think we should also backport the copyright dates from jdk17. |
|
@keithc-ca Was your message misinterpreted? I can make the correction. |
Perhaps I didn't look at the dates closely enough. For example, |
Internal issue -
JVMJ9VM011W Unable to load j9jit29: JVMPORT015E Unable to resolve shared library references - a prerequisite shared library may be missing
The OpenJDK code is backported from jdk17.
8242468: VS2019 build missing vcruntime140_1.dll
In the PR build, vcruntime140_1.dll is included in the bin directory and the java.base.jmod (as expected).
On a system without vcruntime140_1.dll, the PR build runs without error, while the last nightly build gets the error shown above.
Signed-off-by: Peter Shipton Peter_Shipton@ca.ibm.com