Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include vcruntime140_1.dll when compiling with VS2019 #574

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

pshipton
Copy link
Member

@pshipton pshipton commented Sep 8, 2022

Internal issue - JVMJ9VM011W Unable to load j9jit29: JVMPORT015E Unable to resolve shared library references - a prerequisite shared library may be missing

The OpenJDK code is backported from jdk17.
8242468: VS2019 build missing vcruntime140_1.dll

In the PR build, vcruntime140_1.dll is included in the bin directory and the java.base.jmod (as expected).
On a system without vcruntime140_1.dll, the PR build runs without error, while the last nightly build gets the error shown above.

Signed-off-by: Peter Shipton Peter_Shipton@ca.ibm.com

@pshipton
Copy link
Member Author

pshipton commented Sep 8, 2022

jenkins compile win jdk11

@pshipton
Copy link
Member Author

pshipton commented Sep 8, 2022

jenkins compile win jdk11

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@pshipton
Copy link
Member Author

pshipton commented Sep 8, 2022

jenkins compile win jdk11

@pshipton pshipton marked this pull request as ready for review September 9, 2022 00:33
@babsingh
Copy link
Member

babsingh commented Sep 9, 2022

  • Why didn't we change the copyright to 2022?
  • Otherwise, LGTM.

@pshipton
Copy link
Member Author

pshipton commented Sep 9, 2022

The OpenJDK changes backported were made in 2020, so I used that date.

@pshipton
Copy link
Member Author

pshipton commented Sep 9, 2022

@keithc-ca do you have an opinion on what copyright date to use?

@keithc-ca
Copy link
Member

I think we should also backport the copyright dates from jdk17.

@babsingh babsingh merged commit 6b49cb4 into ibmruntimes:openj9 Sep 12, 2022
@keithc-ca
Copy link
Member

@babsingh Why did you merge this before @pshipton had a chance to update the copyright dates?

@babsingh
Copy link
Member

babsingh commented Sep 12, 2022

@babsingh
Copy link
Member

@keithc-ca Was your message misinterpreted? I can make the correction.

@keithc-ca
Copy link
Member

Perhaps I didn't look at the dates closely enough. For example, spec.gmk.in has a current copyright date in jdk17 of 2021, but this change leaves that date at 2020: that sort of discrepancy was the basis for my comment. However, if we consider the date when the change was committed to jdk17, it is actually 2020, so I think everything is fine. Sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants