Expand OpenSSL Version granularity #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be done first in the head stream, reviewed, and then backported. |
|
Doing the head stream, will backport to 11. |
WilburZjh
force-pushed
the
ExpandOpensslVersionGranularly
branch
from
b408e44
to
73f61be
Compare
WilburZjh
changed the title
|
port from Head stream #554 |
|
@keithc-ca @pshipton please help to review |
keithc-ca
requested changes
Mar 9, 2023
closed/src/java.base/share/classes/jdk/crypto/jniprovider/NativeCrypto.java
Outdated
Show resolved
Hide resolved
WilburZjh
force-pushed
the
ExpandOpensslVersionGranularly
branch
2 times, most recently
from
2558a5f
to
7f4c024
Compare
keithc-ca
requested changes
Mar 10, 2023
closed/src/java.base/share/classes/jdk/crypto/jniprovider/NativeCrypto.java
Show resolved
Hide resolved
WilburZjh
force-pushed
the
ExpandOpensslVersionGranularly
branch
2 times, most recently
from
8a798b7
to
17a05f4
Compare
Additional granularity for tracking versions is needed in Native code to make better branching decisions based upon the library versions. Currently, there is differentiation only between <=1.0.x and >=1.1.0. Version 1.1.1 will be supported until 2023-09-11, versions including 1.1.0, 1.0.2, 1.0.1, 1.0.0, and 0.9.8 are no longer supported. We need to add support for separate versions to deprecate/add features in the future. Signed-off-by: Jinhang Zhang <Jinhang.Zhang@ibm.com>
WilburZjh
force-pushed
the
ExpandOpensslVersionGranularly
branch
from
17a05f4
to
f011937
Compare
|
Jenkins test sanity alinux64 jdk11 |
keithc-ca
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional granularity for tracking versions is needed in Native code to make better branching decisions based upon the library versions. Currently, there is differentiation only between <=1.0.x and >=1.1.0. Since, version 1.1.1 will be supported until 2023-09-11 and versions including 1.1.0, 1.0.2, 1.0.1, 1.0.0, and 0.9.8 are no longer supported. We need to add support for separate versions to deprecate/add features in the future.