Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't test unavailable algorithms #670

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

keithc-ca
Copy link
Member

Support for EdDSA, Ed25519 and Ed448 was added in Java 15.

Fixes: eclipse-openj9/openj9#17579.

Support for EdDSA, Ed25519 and Ed448 was added in Java 15.

Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
@keithc-ca
Copy link
Member Author

Jenkins test sanity.openjdk alinux64 jdk11

@keithc-ca
Copy link
Member Author

Strange: the test job didn't use this change; instead it used the current openj9 branch - b33416dc888.

 Using OPENJDK_REPO = [11:[aarch64_linux:https://github.com/ibmruntimes/openj9-openjdk-jdk11.git]] OPENJDK_BRANCH = [11:[aarch64_linux:openj9]] OPENJDK_SHA = [11:[aarch64_linux:]]

I've launched a grinder instead: https://openj9-jenkins.osuosl.org/job/Grinder/2502.

@JasonFengJ9
Copy link
Member

https://openj9-jenkins.osuosl.org/job/Grinder/2502/consoleFull

12:41:59  STDERR:
12:41:59  java.lang.IllegalArgumentException: Key must be at least 160 bits
12:41:59  	at com.evilprovider.EvilHmacSHA1.engineInit(EvilHmacSHA1.java:44)
12:41:59  	at java.base/javax.crypto.Mac.init(Mac.java:433)
12:41:59  	at java.base/com.sun.crypto.provider.PBKDF2KeyImpl.deriveKey(PBKDF2KeyImpl.java:182)
12:41:59  	at java.base/com.sun.crypto.provider.PBKDF2KeyImpl.<init>(PBKDF2KeyImpl.java:122)
12:41:59  	at java.base/com.sun.crypto.provider.PBKDF2Core.engineGenerateSecret(PBKDF2Core.java:69)
12:41:59  	at java.base/javax.crypto.SecretKeyFactory.generateSecret(SecretKeyFactory.java:338)
12:41:59  	at SecKeyFacSunJCEPrf.main(SecKeyFacSunJCEPrf.java:63)
12:41:59  	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
12:41:59  	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
12:41:59  	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
12:41:59  	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
12:41:59  	at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
12:41:59  	at java.base/java.lang.Thread.run(Thread.java:839)
12:41:59  
12:41:59  JavaTest Message: Test threw exception: java.lang.IllegalArgumentException: Key must be at least 160 bits

This is a known failure - jdk_security2_0_FAILED javax/crypto/SecretKeyFactory/SecKeyFacSunJCEPrf.java IllegalArgumentException: Key must be at least 160 bits

@JasonFengJ9
Copy link
Member

Strange: the test job didn't use this change; instead it used the current openj9 branch - b33416dc888.

I think this is a known issue as well, the test change is not picked up, it was determined a low priority item.

FYI @AdamBrousseau

@keithc-ca
Copy link
Member Author

#669 should fix that failure.

@keithc-ca
Copy link
Member Author

I think this is a known issue as well, the test change is not picked up, it was determined a low priority item.

This may become a more important issue with an increased focus on testing security-related changes.

@JasonFengJ9
Copy link
Member

Created an issue - ibmruntimes/openj9-openjdk-jdk#613

Copy link
Member

@JasonFengJ9 JasonFengJ9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the grinder passed the tests in question.

@JasonFengJ9 JasonFengJ9 merged commit 0f2be98 into ibmruntimes:openj9 Jun 13, 2023
3 of 5 checks passed
@keithc-ca keithc-ca deleted the cloneable branch June 13, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants