Remove useless definitions of make macros #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These symbols would only be used if STATIC_BUILD is true: INCLUDE_CUSTOM_EXTENSION_SYMBOLS INCLUDE_CUSTOM_EXTENSION_LIB The configuration option --enable-static-build is only accepted on macOS, but we don't use that option and it would fail anyway with errors like No rule to make target .../vm/runtime/libmanagement_ext.a and various other static libraries. Also remove redundant '-c' from CFLAGS. Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
pshipton
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These symbols would only be used if
STATIC_BUILDistrue:The configuration option
--enable-static-buildis only accepted on macOS, but we don't use that option and it would fail anyway with errors likeand various other static libraries.
Also remove redundant
-cfromCFLAGS.See also ibmruntimes/openj9-openjdk-jdk#692.