Revert to Java impl when non-default SecureRandom present #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshipton
reviewed
Dec 12, 2023
KostasTsiounis
force-pushed
the
secure_random
branch
from
0f6bc85
to
158ea3f
Compare
|
jenkins copyright check |
|
jenkins compile amac jdk11 |
pshipton
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one initializes any of the
NativeECKeyPairGeneratororNativeXDHKeyPairGeneratorwith aSecureRandomimplementation, it is effectively ignored, as the equivalent OpenSSL code is used instead.This fix changes that to using OpenSSL only when no or the default Sun implementation of
SecureRandomis provided. In any other case, the original Java implementation is used to generate the appropriateKeyPair.Back-ported from: ibmruntimes/openj9-openjdk-jdk#711
Signed-off by: Kostas Tsiounis kostas.tsiounis@ibm.com