Add NotCheckpointSafe annotations to PhantomCleanable #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add NotCheckpointSafe annotations to PhantomCleanable to avoid blocking operations during restore in CRIU single thread mode, and fix the failures in the cmdLineTester_criu_nonPortableRestore tests that occur due to blocking operations during restore in CRIU single thread mode. Issue: eclipse-openj9/openj9#18749 Signed-off-by: Amarpreet Singh <Amarpreet.A.Singh@ibm.com>
singh264
force-pushed
the
openj9_issues_18749
branch
from
0d4059e
to
8b5f072
Compare
|
@tajila requesting your review. |
TobiAjila
approved these changes
Jan 14, 2024
|
@JasonFengJ9 please review/merge |
|
jenkins test sanity xmac,alinux64 jdk11 |
JasonFengJ9
approved these changes
Jan 15, 2024
|
This should not have been merged until after equivalent changes have been applied to later versions (jdk17, jdk21, jdk22, jdknext). @singh264 Please prepare changes for those versions. |
|
@keithc-ca those equivalent changes were merged a while ago, this is the Java level not applied initially. |
|
I see that now. Sorry for the interruption. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add NotCheckpointSafe annotations to PhantomCleanable to
avoid blocking operations during restore in CRIU single
thread mode, and fix the failures in the
cmdLineTester_criu_nonPortableRestore tests that occur due
to blocking operations during restore in CRIU single
thread mode.
Issue: eclipse-openj9/openj9#18749
Signed-off-by: Amarpreet Singh Amarpreet.A.Singh@ibm.com