This repository has been archived by the owner on Oct 22, 2020. It is now read-only.
Add new flag J9VM_OPT_JITSERVER to enable JITServer #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@keithc-ca can you please review. |
|
See eclipse-openj9/openj9#8656 for related OpenJ9 change. |
The macro used for building JITServer in OpenJ9 is changed from JITSERVER_SUPPORT to J9VM_OPT_JITSERVER. The makefile OpenJ9.mk needs to be updated to set the correct env variable. Signed-off-by: Ashutosh Mehra <mehra.ashutosh@ibm.com>
keithc-ca
approved these changes
Feb 27, 2020
|
None of the jdk14 platforms which do not normally enable JITserver compile. |
keithc-ca
reviewed
Feb 28, 2020
| else | ||
| FEATURE_SED_SCRIPT += $(call SedDisable,build_jitserver) | ||
| FEATURE_SED_SCRIPT += $(call SedEnable,opt_jitserver) |
There was a problem hiding this comment.
This should call SedDisable; once my local build completes. I'll open a pull request to fix it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macro used for building JITServer in OpenJ9 is changed from
JITSERVER_SUPPORT to J9VM_OPT_JITSERVER. The makefile OpenJ9.mk
needs to be updated to set the correct env variable.
Older env variable JITSERVER_SUPPORT would be kept until changesin OpenJ9 are not done to avoid any build breaks.
Signed-off-by: Ashutosh Mehra mehra.ashutosh@ibm.com