Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JDK16 extension changes to enable OJDK MHs #29

Merged
merged 3 commits into from
Jul 5, 2021
Merged

JDK16 extension changes to enable OJDK MHs #29

merged 3 commits into from
Jul 5, 2021

Conversation

babsingh
Copy link
Member

@babsingh babsingh commented Feb 12, 2021 •
edited
Loading

  1. Revert "OpenJ9 support for the Foreign Memory Access API"
  2. 8259922: MethodHandles.collectArguments does not throw IAE if pos is … (back-ported from JDK-next)
  3. Enable OpenJDK MHs for OpenJ9 JDK16 by default (back-ported from Enable OpenJDK MHs for OpenJ9 JDK17 by default openj9-openjdk-jdk#308 + Fix feedback for '--enable-openjdk-methodhandles' openj9-openjdk-jdk#309)

This PR is created to launch OpenJ9 PR build jobs with OJDK MHs enabled in OpenJ9.

It should not be merged.

@babsingh babsingh mentioned this pull request Feb 12, 2021
Merged
@babsingh babsingh changed the title JDK16 extension changes to enable OJDK MH JDK16 extension changes to enable OJDK MHs Feb 12, 2021
@pshipton
Copy link
Member

We don't need the PR, builds can depend on the branch directly.

@babsingh babsingh closed this Feb 12, 2021
@pshipton
Copy link
Member

Ok, looks like I was wrong. I guess we can't use a branch from a fork.

@pshipton pshipton reopened this Feb 12, 2021
@0xdaryl 0xdaryl mentioned this pull request Mar 4, 2021
Merged
@babsingh babsingh mentioned this pull request Mar 6, 2021
Merged
@DanHeidinga DanHeidinga mentioned this pull request Mar 16, 2021
Merged
@gacholio gacholio mentioned this pull request Mar 26, 2021
Merged
@DanHeidinga DanHeidinga mentioned this pull request Mar 26, 2021
Merged
@babsingh babsingh mentioned this pull request Apr 1, 2021
Merged
@DanHeidinga DanHeidinga mentioned this pull request Apr 1, 2021
Merged
This was referenced Apr 6, 2021
Merged
Merged
Merged
@DanHeidinga DanHeidinga mentioned this pull request Apr 21, 2021
Merged
@babsingh babsingh mentioned this pull request Apr 22, 2021
Merged
@DanHeidinga DanHeidinga mentioned this pull request May 12, 2021
Merged
@gacholio gacholio mentioned this pull request May 18, 2021
Merged
@fengxue-IS
Copy link
Contributor

fengxue-IS commented Jun 14, 2021 •
edited
Loading

I suspect that all the bindCaller failures in sanity.openjdk will be fixed by eclipse-openj9/openj9#12716, will test with this PR to verify

This was referenced Jun 15, 2021
Merged
Merged
@fengxue-IS
Copy link
Contributor

Tested locally that all sanity.openjdk test failures due to bindCaller is fixed by eclipse-openj9/openj9#12716

@fengxue-IS
Copy link
Contributor

fengxue-IS commented Jun 15, 2021 •
edited
Loading

extended.functional update:

cmdLineTester_getCallerClassTests_0 failed due to checking for java.lang.invoke.SecurityFrame which doesn't exist in OpenJDK MH, will look into disabling these tests
UnreflectTests_0 failed due to the exclude test listener not applied, opened PR eclipse-openj9/openj9#12976 to fix exclude issue

@fengxue-IS fengxue-IS mentioned this pull request Jun 15, 2021
Merged
@gacholio gacholio mentioned this pull request Jun 18, 2021
Merged
This was referenced Jun 24, 2021
Merged
Merged
@fengxue-IS fengxue-IS mentioned this pull request Jun 24, 2021
Merged
@DanHeidinga DanHeidinga mentioned this pull request Jun 28, 2021
Merged
@fengxue-IS
Copy link
Contributor

update: latest build of OJDK MH for Java 17 extended.system SharedClasses.SCM23.SingleCL_1 passed

@llxia llxia mentioned this pull request Jun 30, 2021
Merged
This was referenced Jul 5, 2021
Closed
Merged
@tajila
Copy link
Member

tajila commented Jul 5, 2021 •
edited
Loading

@pshipton can we merge this?

The jdk16 excludes were merged

@pshipton pshipton merged commit 7e526d0 into ibmruntimes:openj9 Jul 5, 2021
@pshipton
Copy link
Member

pshipton commented Jul 6, 2021 •
edited
Loading

See the failures in https://openj9-jenkins.osuosl.org/job/Pipeline-Build-Test-JDK16/44/

@pshipton
Copy link
Member

pshipton commented Jul 6, 2021 •
edited
Loading

The extended.functional testvmcheck failures occur on Java 11 as well, so not related to OJDK MH.
eclipse-openj9/openj9#13120

@tajila tajila mentioned this pull request Jul 6, 2021
Merged
@tajila
Copy link
Member

tajila commented Jul 6, 2021

@fengxue-IS Is cmdLineTester_getCallerClassTests_0 the failure the JIT team is investigating?

@fengxue-IS
Copy link
Contributor

no, the JIT failure has been excluded, cmdLineTester_getCallerClassTests_0 should be fixed by eclipse-openj9/openj9#13081

@pshipton
Copy link
Member

pshipton commented Jul 6, 2021

Other failures

eclipse-openj9/openj9#13126
eclipse-openj9/openj9#13127
eclipse-openj9/openj9#13128
eclipse-openj9/openj9#13129

@pshipton
Copy link
Member

pshipton commented Jul 7, 2021

New one
eclipse-openj9/openj9#13132

The following re-occurred. This adds overhead to daily triage, and the failures are archiving artifacts which may cause a space issue.
eclipse-openj9/openj9#13126
eclipse-openj9/openj9#13127
eclipse-openj9/openj9#13129

@pshipton
Copy link
Member

pshipton commented Jul 8, 2021

New one
eclipse-openj9/openj9#13142

Re-occurred, same as previous comment.

This was referenced Jul 22, 2021
Merged
Merged
This was referenced Apr 14, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshipton pshipton pshipton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@babsingh @pshipton @tajila @fengxue-IS @DasBrain