Update the FFI related code intended for JEP434 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: Reviewer: @tajila, @keithc-ca |
This was referenced Mar 6, 2023
ChengJin01
force-pushed
the
ffi_update_code_against_latest_apis_jep434
branch
3 times, most recently
from
e10ed75
to
a2554bb
Compare
ChengJin01
force-pushed
the
ffi_update_code_against_latest_apis_jep434
branch
from
a2554bb
to
13f5155
Compare
|
The PR was updated with the same changes as requested by Keith against the comments at ibmruntimes/openj9-openjdk-jdk#559. |
ChengJin01
force-pushed
the
ffi_update_code_against_latest_apis_jep434
branch
2 times, most recently
from
8b44424
to
cc782e4
Compare
keithc-ca
requested changes
Mar 22, 2023
src/java.base/share/classes/jdk/internal/foreign/abi/AbstractLinker.java
Outdated
Show resolved
Hide resolved
The changes update part of our code in the FFI framework against the latest APIs specified in JDK20 to accommodate the new features of JEP434. Note: This is the part of implementation intended for #eclipse-openj9/openj9/issues/16329 Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
ChengJin01
force-pushed
the
ffi_update_code_against_latest_apis_jep434
branch
from
cc782e4
to
50d879d
Compare
|
Jenkins compile alinux64 jdk20 depends eclipse-openj9/openj9#16835 |
keithc-ca
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes update part of our code in the FFI
framework against the latest APIs specified in
JDK20 to accommodate the new features of JEP434.
Note:
This is the part of implementation intended for
#eclipse-openj9/openj9/issues/16329
Signed-off-by: ChengJin01 jincheng@ca.ibm.com