[FFI/JTreg] Remove the pragma lines for AIX in test suites #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following test suites in the issues listed in the description passed with the changes in this PR: Reviewer: @keithc-ca |
The intention of the changes is to avoid conflicts with our own code with 4-byte alignment for double on AIX which already supports both the default setting by the compiler and the natural alignment for double. Fixes: #eclipse-openj9/openj9/issues/18940, #eclipse-openj9/openj9/issues/18941, #eclipse-openj9/openj9/issues/18942, #eclipse-openj9/openj9/issues/18943 Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
ChengJin01
force-pushed
the
ffi_remove_pragma_lines_aix_double_jdk22
branch
from
62f1826
to
e7c3f31
Compare
keithc-ca
approved these changes
Mar 7, 2024
|
I don't think testing this is worthwhile, it essentially reverts and tests were passing before that change. |
This was referenced Mar 7, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention of the changes is to avoid conflicts
with our own code with 4-byte alignment for double on
AIX which already supports both the default setting
by the compiler and the natural alignment for double.
Fixes: #eclipse-openj9/openj9/issues/18940, #eclipse-openj9/openj9/issues/18941, #eclipse-openj9/openj9/issues/18942, #eclipse-openj9/openj9/issues/18943
Signed-off-by: ChengJin01 jincheng@ca.ibm.com