Acquire interruptLock for interruptImpl and isInterruptedImpl #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
interruptImpl and isInterruptedImpl use the eetop/threadRef value. Acquiring interruptLock assures that the eetop/threadRef value won't change during interruptImpl and isInterruptedImpl. This will prevent crashes which happen when a stale eetop/threadRef value is used to invoke OMR thread library functions. Related: eclipse-openj9/openj9#19544 Related: eclipse-openj9/openj9#19598 Related: eclipse-openj9/openj9#19816 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
requested review from
pshipton and
tajila
and removed request for
pshipton
|
@pshipton is away today. @tajila This PR addresses eclipse-openj9/openj9#19816. |
|
is this a backport? |
Yes, it is a backport of ibmruntimes/openj9-openjdk-jdk#803. The fix was pushed around the same time when the JDK23 extensions repo was created; I was expecting the JDK23 repo to pick up the fix from the JDK-next repo during creation, but it didn't happen. |
|
jenkins test sanity alinux64 jdk23 |
pshipton
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
interruptImplandisInterruptedImpluse theeetop/threadRefvalue.Acquiring
interruptLockassures that theeetop/threadRefvalue won'tchange during
interruptImplandisInterruptedImpl. This will preventcrashes which happen when a stale
eetop/threadRefvalue is used toinvoke OMR thread library functions.
Related: eclipse-openj9/openj9#19544
Related: eclipse-openj9/openj9#19598
Related: eclipse-openj9/openj9#19816
Backport of ibmruntimes/openj9-openjdk-jdk#803