Add jitserver launcher in OpenJ9 builds #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi - @keithc-ca |
ashu-mehra
force-pushed
the
include_jitserver_launcher
branch
from
d0984b1
to
3a330b2
Compare
|
@pshipton @keithc-ca can you please review this PR. It is required for eclipse-openj9/openj9#7940. |
|
@pshipton @keithc-ca can you please review this PR. |
pshipton
approved these changes
Jan 2, 2020
keithc-ca
requested changes
Jan 2, 2020
ashu-mehra
force-pushed
the
include_jitserver_launcher
branch
from
3a330b2
to
1db21da
Compare
|
Other than the copyright dates, this looks good now. |
ashu-mehra
force-pushed
the
include_jitserver_launcher
branch
from
1db21da
to
95f91be
Compare
|
Fixed the copyright date. |
keithc-ca
reviewed
Jan 6, 2020
If --enable-jitserver configuration option is set, then enable building of jitserver launcher and include it in the jre or jdk. Signed-off-by: Ashutosh Mehra <mehra.ashutosh@ibm.com>
ashu-mehra
force-pushed
the
include_jitserver_launcher
branch
from
95f91be
to
e99805f
Compare
keithc-ca
approved these changes
Jan 7, 2020
|
I guess this PR can now be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If --enable-jitserver configuration option is set, then enable
building of jitserver launcher and include it in the jre or jdk.
Signed-off-by: Ashutosh Mehra mehra.ashutosh@ibm.com