Add new configure option --with-mixedrefs for mixed pointer mode #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharon-wang
force-pushed
the
mixedbuild
branch
from
f1ffcd8
to
9a7ae63
Compare
This was referenced Nov 12, 2020
|
FYI @keithc-ca @gacholio |
keithc-ca
requested changes
Nov 12, 2020
sharon-wang
force-pushed
the
mixedbuild
branch
from
9a7ae63
to
62bd407
Compare
|
The |
That's a sign that you're using a slightly older version of autoconf (even though it might report it's version 2.69). The one in Ubuntu 18.04 or newer won't do that. |
If --with-mixedrefs is specified in the configure command, the 'default'
OPENJ9_LIBS_SUBDIR is used for the build. The mxdptrs CMake file corresponding
to the build OS is used as the OPENJ9_BUILDSPEC. --with-mixedrefs=[static/dynamic]
sets the reference determination mode. --with-mixedrefs without any value provided
defaults to static mode.
OMR_MIXED_REFERENCES_MODE is communicated to OpenJ9 and OMR through CMake args.
Fail configure if --with-mixedrefs is used without CMake enabled.
The new mxdptr build specs are defined in OpenJ9.
The compressed and full GC libraries generated with the mixed build work are
copied to the OPENJ9_LIBS_SUBDIR alongside the other existing libraries.
j9gc29, j9gcchk29 are always copied
j9gc_full29, j9gcchk_full29 are copied when running in mixedrefs static mode
If an OpenJ9-equivalent OS has been specified in OPENJ9_BUILD_OS,
use the specified OS string to override the provided
OPENJDK_BUILD_OS.
Use OPENJ9_BUILD_MODE_ARCH to capture the other half of the
OPENJ9_BUILDSPEC, where the architecture and the pointer mode
(or other additional modes/settings) are specified.
Signed-off-by: Sharon Wang <sharon-wang-cpsc@outlook.com>
sharon-wang
force-pushed
the
mixedbuild
branch
from
62bd407
to
a8263c3
Compare
|
Yes, I was building on OSX and it was reporting v2.69 for autoconf. I've run the autogen script again on Ubuntu 20.04 -- |
|
Jenkins compile aix,osx,win,win32,zlinux jdk8 |
keithc-ca
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JDK8 port of ibmruntimes/openj9-openjdk-jdk11#359.
Related Issue: eclipse-openj9/openj9#8878