Support configure option '--with-openssl=fetched' on Windows #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshipton
reviewed
Jan 21, 2022
closed/openssl.gmk
Outdated
| endif | ||
| else ifeq ($(OPENJDK_TARGET_OS), macosx) | ||
| ifeq ($(OPENJDK_TARGET_CPU), arm64) | ||
| OPENSSL_TARGET := darwin64-x86_64-cc |
There was a problem hiding this comment.
This specifies x86 instead of arm.
There was a problem hiding this comment.
Good catch. I inverted that 'ifeq' element badly.
There was a problem hiding this comment.
I plan to replace the series of CPU cases to:
ifneq (,$(filter arm64 x86_64, $(OPENJDK_TARGET_CPU)))
OPENSSL_TARGET := darwin64-$(OPENJDK_TARGET_CPU)-cc
endif
and apply a similar change for Linux.
|
Fixed calculation of |
This was referenced Jan 21, 2022
Merged
Merged
Merged
Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
|
Updated calculation of |
pshipton
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: eclipse-openj9/openj9#14302.