Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use short name on Windows for vcruntime140.dll #615

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

pshipton
Copy link
Member

@pshipton pshipton commented Sep 27, 2022

This change is also seen in jdk11
ibmruntimes/openj9-openjdk-jdk11@be05050

Testing ongoing in https://openj9-jenkins.osuosl.org/job/Pipeline-Build-Test-Personal/250/
It's not done, but the configure output looks good.

Issue eclipse-openj9/openj9#15962

This change is also seen in jdk11
ibmruntimes/openj9-openjdk-jdk11@be05050

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@keithc-ca
Copy link
Member

This is essentially the same as #616 (I didn't realize you were working on this), minus the copyright notice.

@keithc-ca
Copy link
Member

configure output looks good

And the build output shows the right name is included in images

15:55:15  j2sdk-image/bin/vcruntime140.dll
15:55:17  j2sdk-image/jre/bin/vcruntime140.dll

Can you fix the missing copyright?

@pshipton
Copy link
Member Author

Can you fix the missing copyright?

Since the change can be considered backported from jdk11, I didn't add an IBM copyright.

@pshipton
Copy link
Member Author

btw, I don't think this fixes eclipse-openj9/openj9#15962, but it's part 1 to get it working. There is also this part:
"
After going through preloadLibrary code, we figured it might be a problem with the way the preload libraries are being Loaded.

https://github.com/eclipse-openj9/openj9/blob/v0.27.0-release/runtime/j9vm/jvm.c#:~:text=LOAD_WITH_ALTERED_SEARCH_PATH

Since, altered searched strategy is used instead of standard search strategy, vcruntime140.dll is being searched in dll directory (JRE_HOME/bin/default/) instead of application directory (JRE_HOME/bin/) for certain LoadLibraryEx calls.
"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants