Fix race condition in jdwp #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdbain-ibm
force-pushed
the
fix_jdwp
branch
2 times, most recently
from
717f41f
to
a7f4280
Compare
Normally, the event helper thread suspends all threads, then the debug loop in the listener thread receives a command to resume. The debugger may deadlock if the debug loop in the listener thread starts processing commands (e.g. resume threads) before the event helper completes the initialization (and suspends threads). This patch adds synchronization to ensure the event helper completes the initialization sequence before debugger commands are processed. Signed-off-by: Peter Bain <peter_bain@ca.ibm.com>
|
@andrew-m-leonard @adamfarley would you kindly review this? |
|
Similar problems as ibmruntimes/openj9-openjdk-jdk9#138. @pdbain-ibm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally, the event helper thread suspends all threads, then the debug loop in
the listener thread receives a command to resume. The debugger may deadlock if
the debug loop in the listener thread starts processing commands (e.g. resume
threads) before the event helper completes the initialization (and suspends
threads).
This patch adds synchronization to ensure the event helper completes the
initialization sequence before debugger commands are processed.
@andrew-m-leonard FYI.
Signed-off-by: Peter Bain peter_bain@ca.ibm.com