implement injection of TWC saver for Chrome #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
another thing to note and probably to fix: in some places description says that Timimi is for TW5 while it's more for TW in general. For instance, this is written in readme that is show after installing both backends (for FF and for Chrome), presumably that's Timimi/installer/windows/readme.txt. Also Timimi/installer/windows/firefox-json/timimi.json and Timimi/installer/windows/chrome-json/timimi.json state "Native messaging host to save TW5", should be "Native messaging host to save TiddlyWiki" (or "TWC and TW5"). |
|
Congratulations @YakovL You did it.I tested in chrome and saving works. Once I am done fixing a few unrelated bugs, it will be pushed to the chrome store. Great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So here's my first approach to fixing saving of TWC in Chrome. Since I haven't succeeded in making local unpacked extension to work with Timimi backend yet (on Windows, see #44 for details), this is not fully tested and may need to be fixed further. Another thing to note is this change can be applied to Firefox extension as well so that the codebase is the same (haven't tested it yet though).