specs opacity fix #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
el.style.opacity returns a string, not a number http://jsfiddle.net/eLLMT/
timwienk
added a commit
to timwienk/mootools-core
that referenced
this pull request
Mar 6, 2014
el.style.opacity returns a string, not a number. http://jsfiddle.net/eLLMT/ added specs for both version of setter for opacity. <1.4 and 1.4+ * opacityfix: opacity setter specs specs opacity fix
timwienk
added a commit
to timwienk/mootools-core
that referenced
this pull request
Mar 6, 2014
Awesome massive work done by: - @ibolmo - @ibolmo - @GCheung55 - @kentaromiura - @SergioCrisostomo - @ibolmo * specs: (52 commits) Fix key event spec, because our old syn bugs on escape. Fix a Video Element spec that breaks in IE if some extensions are not installed. In README, correct path to point to mootools. Local testing info. (ibolmo#18) Fix for Sinon / All IE. (ibolmo#17) Patch for Sinon-IE (IE7-9). (ibolmo#16, GCheung55#2) Fix specs to look for correct behaviour since 1.3. (ibolmo#13) Update ports and sauce tasks. (ibolmo#15) Function bind spec fix. (ibolmo#12) Restored original syntax in Element specs. (ibolmo#11) Opacity specs. (ibolmo#10, ibolmo#14) Add missing devDeps. (ibolmo#9) ...
timwienk
added a commit
to timwienk/mootools-core
that referenced
this pull request
Mar 6, 2014
Awesome massive work done by: - @ibolmo - @ibolmo - @GCheung55 - @kentaromiura - @SergioCrisostomo - @ibolmo * specs: (70 commits) Fix key event spec, because our old syn bugs on escape. Fix a Video Element spec that breaks in IE if some extensions are not installed. In README, correct path to point to mootools. Local testing info. (ibolmo#18) Fix for Sinon / All IE. (ibolmo#17) Patch for Sinon-IE (IE7-9). (ibolmo#16, GCheung55#2) Fix specs to look for correct behaviour since 1.3. (ibolmo#13) Update ports and sauce tasks. (ibolmo#15) Function bind spec fix. (ibolmo#12) Restored original syntax in Element specs. (ibolmo#11) Opacity specs. (ibolmo#10, ibolmo#14) Add missing devDeps. (ibolmo#9) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
el.style.opacity returns a string, not a number
http://jsfiddle.net/eLLMT/