New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Long-term temperature changes of geothermal bore fields #1107
Comments
A validation case was added in |
…), 7.5*floor((i-1)/10)} for i in 1:100}. See comment from 6/7/19 in issue
The command
fails with a compilation error. The problematic assignment is
in |
I reopen this issue for testing of |
There is an issue with the integration of the finite line source solution in
IBPSA.Fluid.Geothermal.Borefields.BaseClasses.HeatTransfer.ThermalResponseFactors.finiteLineSource
. The upper bound of integration (in theory infinite) is set to 100.0. This is a correct upper limit for typical boreholes with diameters of the order of 6 inches.However, in the implementation of the thermal response we decided to evaluate the finite line source analytical solution at a radius
radius = 0.0005*length
. For shorter boreholes (approx. 25 m or less), the radius becomes small and the integrand function is still non-negligible at a value of 100.0. The figure below shows the logarithm (log10) of the integrand.This causes issues with the calculation of the thermal response, and becomes progressively worse with decreasing borehole length, as shown below for a 5 meter borehole (the thermal response should be strictly positive).
A conservative estimate for the upper bound of integration is
10/radius
, or20000/length
in our case. This corrects the thermal response, see below.The text was updated successfully, but these errors were encountered: