New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
guard against low pressures #1148
Comments
How was such a low pressure achieved? Through a signal input, or through a parameter? I would think catching this at the source would be more efficient than in the volume, e.g., in the solution to an ODE. |
Good point, through a parameter in this case. The |
What do you mean by the chemical formula? Is there anything in |
constant Modelica.Media.Interfaces.Types.Basic.FluidConstants[1]
simpleWaterConstants(
each chemicalFormula="H2O",
each structureFormula="H2O",
each casRegistryNumber="7732-18-5",
each iupacName="oxidane",
each molarMass=0.018015268); However I did not realize that we cannot use this since it does not exist in |
If the string is compared only once, then this would be fine. But I thought we call |
I just had an issue where someone set an air pressure of 10 Pa, which caused negative absolute humidities to be computed, leading to funny computations elsewhere. The simulation however did not crash, stop or error. Should we somehow check/guard against these kind of errors to avoid wrong results to be generated? We could integrate an assert in some partials, perhaps in a mixing volume and/or medium implementation. However, this will generate overhead.. Any thoughts on this?
The text was updated successfully, but these errors were encountered: