Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IncludeThreeWayTable Valve #1254

Closed
alexanderAKU opened this issue Nov 15, 2019 · 2 comments · Fixed by #1256
Closed

IncludeThreeWayTable Valve #1254

alexanderAKU opened this issue Nov 15, 2019 · 2 comments · Fixed by #1256

Comments

@alexanderAKU
Copy link
Contributor

This issue is the extension of issue #1227:

Currently, the library contains a table based two way valve. However, a table based three way valve is not included yet.

The model new model ThreeWayTable will extend from the PartialThreeWayValve and replace the partial models res1 and res3 by the model TwoWayTable
@alexanderAKU
Copy link
Contributor Author

@mwetter could you create a branch with the name issue1254_includeThreeWayTableValve so that I can push my changes to the repository?

@mwetter
Copy link
Contributor

mwetter commented Nov 18, 2019

@alexanderAKU : I created the branch https://github.com/ibpsa/modelica-ibpsa/tree/issue1254_includeThreeWayTableValve

alexanderAKU pushed a commit to RWTH-EBC/modelica-ibpsa that referenced this issue Nov 27, 2019
ibpsa#1254 ThreeWayTable.mo and Examples/ThreeWayTable.mo added
5269cca
alexanderAKU pushed a commit to RWTH-EBC/modelica-ibpsa that referenced this issue Nov 27, 2019
ibpsa#1254 info section of ThreeWayTable.mo and Examples/ThreeWayTabl…
ee33ae8 
…e.mo modified
@mwetter mwetter mentioned this issue Nov 28, 2019
Merged
1 task
alexanderAKU pushed a commit to RWTH-EBC/modelica-ibpsa that referenced this issue Dec 17, 2019
ibpsa#1254 Add Valves.ThreeWayTable model to Valves.Examples.ThreeWay…
a5cb9ce 
…Valves example and delete example Valves.Examples.ThreeWayTable
alexanderAKU pushed a commit to RWTH-EBC/modelica-ibpsa that referenced this issue Dec 17, 2019
ibpsa#1254 revised revisions
ea04339
alexanderAKU pushed a commit to RWTH-EBC/modelica-ibpsa that referenced this issue Dec 17, 2019
ibpsa#1254 Scripts/Dymola/Fluid/Actuators/Valves/Examples/ThreeWayTab…
7325973 
…le.mos deleted and script ThreeWayValve modified
alexanderAKU pushed a commit to RWTH-EBC/modelica-ibpsa that referenced this issue Dec 17, 2019
ibpsa#1254 revision of Examples/ThreeWayValves.mo modified
6c2c9d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue1254 include three way table valve ibpsa/modelica-ibpsa
2 participants
@mwetter @alexanderAKU