Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue warning for fluid sensors with one port #1399

Closed
mwetter opened this issue Sep 20, 2020 · 2 comments · Fixed by #1400
Closed

Issue warning for fluid sensors with one port #1399

mwetter opened this issue Sep 20, 2020 · 2 comments · Fixed by #1400
Assignees

Comments

@mwetter
Copy link
Contributor

mwetter commented Sep 20, 2020

This issue is to remove sensors in IBPSA.Fluid.Sensors that have only one port and whose output depends on the flow direction.

Instead of these sensors, it is better to use their version that have two fluid ports, as is described in IBPSA.Fluid.Sensors.UsersGuide.

The one port sensors are removed because many users use them, including users who attended a workshop where we explained to them when and why not to use them, and made them aware of the info in IBPSA.Fluid.Sensors.UsersGuide.

See also https://github.com/ibpsa/project1/wiki/2020-09-15-library-development#1-port-sensors-such-as-for-temperature

@mwetter mwetter self-assigned this Sep 20, 2020
@mwetter
Copy link
Contributor Author

mwetter commented Sep 20, 2020

Todo:

  • Add warnings to sensors that have one port.
  • Update user guide.
  • Update conversion script.

@mwetter
Copy link
Contributor Author

mwetter commented Sep 20, 2020

There are a few use cases where the sensors with one port make sense, and the use of sensors with two ports would be non-intuitive, or can lead to wrong results if the sensor is configured as dynamic. For example, the image below shows how to measure PPM from a volume with a two port sensor. If configured to be dynamic, then the result is wrong (because there is no flow through the sensor, its output never changes).
image
So, a user would need to configure it as steady-state to measure the PPM in the volume, and likely also set allowFlowReversal=false, although in Dymola, the inflowing enthalpy at port b is equal to the outflowing enthaly if unconnected. (I don't think the standard defines the behavior for this case.)

In view of this, it may be better to write a warning if these sensors are used, and allow the user to disable the warning through a parameter. As there are warnings issued, I think it is fine the leave the temperature sensor with one port in the Fluid.Sensors package. If we were to move it to the Obsolete package, users may use the sensor from the MSL, and then don't get a warning. So I think it is better to leave the sensor so users are warned about potential problems.

@mwetter mwetter changed the title Remove fluid sensors with one port Issue warning for fluid sensors with one port Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant