Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PIDHysteresis and PIDHysteresisTimer obsolete #1522

Closed
mwetter opened this issue Sep 20, 2021 · 2 comments · Fixed by #1523
Closed

Make PIDHysteresis and PIDHysteresisTimer obsolete #1522

mwetter opened this issue Sep 20, 2021 · 2 comments · Fixed by #1523

Comments

@mwetter
Copy link
Contributor

mwetter commented Sep 20, 2021

The controllers IBPSA.Controls.Continuous.PIDHysteresis and IBPSA.Controls.Continuous.PIDHysteresisTimer are not used by AixLib and IDEAS, and Buildings uses only IBPSA.Controls.Continuous.PIDHysteresis in one example, where it is not really needed either. To simplify the library, I suggest to move these two rather convoluted controllers to IDEAS.Obsolete.

@Mathadon @cvering @nytschgeusen : Do you agree?

@Mathadon
Copy link
Member

Ok for me!

@cvering
Copy link
Contributor

cvering commented Sep 20, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants