Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement der_spliceFunction #1531

Closed
mwetter opened this issue Oct 13, 2021 · 0 comments · Fixed by #1532
Closed

Reimplement der_spliceFunction #1531

mwetter opened this issue Oct 13, 2021 · 0 comments · Fixed by #1532
Assignees
@mwetter

Comments

@mwetter
Copy link
Contributor

mwetter commented Oct 13, 2021

Hubertus reported that the current implementation of spliceFunction_der in the MSL (or der_spliceFunction as it is called in the IBPSA library), the cosh function is used. But this causes an overflow if its argument is around 800 which can be very hard to diagnose if it happens in a solver. He provided another implementation with tanh that does not exhibit this potential problem.

This issue is to implement the new formulation.
@mwetter mwetter self-assigned this Oct 13, 2021
mwetter added a commit that referenced this issue Oct 13, 2021
@mwetter
Reimplemented der_spliceFunction
b9c88bf 
For #1531
@mwetter mwetter mentioned this issue Oct 13, 2021
Merged
thorade added a commit to thorade/ModelicaStandardLibrary that referenced this issue Oct 27, 2021
@thorade
spliceFunction refactor
ab5e7ad 
improve readability slightly
remove cosh, because cosh(800+) might return NaN
also see ibpsa/modelica-ibpsa#1531
@thorade thorade mentioned this issue Oct 27, 2021
Merged
beutlich pushed a commit to modelica/ModelicaStandardLibrary that referenced this issue Feb 1, 2022
@thorade
Refactor spliceFunction (#3885)
c15f9d3 
* Improve readability slightly
* Remove cosh, because cosh(800+) might return NaN
* As reported by ibpsa/modelica-ibpsa#1531
@thorade thorade mentioned this issue Sep 27, 2022
Merged
mwetter pushed a commit that referenced this issue Sep 27, 2022
@thorade
der_spliceFunction check limits
9c1f0d4 
this is a follow-up for #1531 and #1532
there are two if-conditions that used a different value:
1 versus 0.9999999999
this PR makes sure the identical limit is used in
spliceFunction and corresponding derivative
@mwetter mwetter mentioned this issue Sep 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwetter mwetter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reimplemented der_spliceFunction ibpsa/modelica-ibpsa
1 participant
@mwetter