Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused parameter p in Fluid.Storage.ExpansionVessel #1614

Closed
mwetter opened this issue May 11, 2022 · 0 comments · Fixed by #1615
Closed

Remove unused parameter p in Fluid.Storage.ExpansionVessel #1614

mwetter opened this issue May 11, 2022 · 0 comments · Fixed by #1615
Assignees
@mwetter
Labels
non-backward compatible

Comments

@mwetter
Copy link
Contributor

mwetter commented May 11, 2022

The model Fluid.Storage.ExpansionVessel declares a parameter

parameter Modelica.Units.SI.Pressure p=Medium.p_default
    "Constant pressure of the expansion vessel";

This parameter is however not used in the model. Instead, p_start is used as the documentation correctly explains. The parameter should therefore be removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwetter mwetter

Labels
non-backward compatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed nonused parameter p in Fluid.Storage.ExpansionVessel ibpsa/modelica-ibpsa
1 participant
@mwetter