Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add assertion in Movers.FlowControlled_m_flow that guards against unreasonable operating points #1659

Closed
mwetter opened this issue Nov 14, 2022 · 2 comments · Fixed by #1661

Comments

@mwetter
Copy link
Contributor

mwetter commented Nov 14, 2022

If Movers.FlowControlled_m_flow is working against closed or almost closed valves or dampers, then unreasonable high pressure drops and power use will occur. I run into such issues every few months when reviewing models.

This issue is to add in Movers.FlowControlled_m_flow code such as this:

protected 
   final parameter Modelica.Units.SI.Pressure dpMaxOpe = 2*max(eff.per.pressure.dp)
   "Maximum pressure allowed to operate the model";
equation 
  assert(senRelPre.p_rel < dpMaxOpe,
    "In " + getInstanceName() + ": Operating model with head dp_actual = " + String(senRelPre.p_rel) + " Pascals 
    which is two times above the pressure defined in the performance record per.pressure.dp = " + String(max(eff.per.pressure.dp)) + "
    This typically happens if the pump or fan forces a high mass flow rate through a closed or almost closed valve or damper,
    or if the performance record is entered unreasonable. Please verify your model.");
@Mathadon
Copy link
Member

Mathadon commented Nov 15, 2022

@mwetter if missing, the documentation may mention this problem and advocate the use of FlowControlled_dp.

@mwetter
Copy link
Contributor Author

mwetter commented Nov 15, 2022

Implement feature, and add a parameter to either disable it or turn it into a warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants