We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annex60.Fluid.Interfaces.PartialTwoPortTransport can be simplified when allowFlowReversal=false:
Annex60.Fluid.Interfaces.PartialTwoPortTransport
allowFlowReversal=false
port_a.Xi_outflow = inStream(port_b.Xi_outflow); port_b.Xi_outflow = inStream(port_a.Xi_outflow); port_a.C_outflow = inStream(port_b.C_outflow); port_b.C_outflow = inStream(port_a.C_outflow);
then becomes
port_a.Xi_outflow = if allowFlowReversal then inStream(port_b.Xi_outflow) else Medium.X_default[1:Medium.nXi]; port_b.Xi_outflow = inStream(port_a.Xi_outflow); port_a.C_outflow = if allowFlowReversal then inStream(port_b.C_outflow) else zeros(Medium.nC); port_b.C_outflow = inStream(port_a.C_outflow);
this is similar to Annex60.Fluid.Interfaces.StaticTwoPortConservationEquation.
Annex60.Fluid.Interfaces.StaticTwoPortConservationEquation
I'll make a pull request.
The text was updated successfully, but these errors were encountered:
for #305 : implemented more efficient code for when allowFlowReversal…
0182939
… = false
Merge pull request #306 from iea-annex60/issue305_partialTwoPortTrans…
5f493db
…portFloRev for #305 : implemented more efficient code for when allowFlowReversal…
This is now on the master.
Sorry, something went wrong.
No branches or pull requests
Annex60.Fluid.Interfaces.PartialTwoPortTransport
can be simplified whenallowFlowReversal=false
:then becomes
this is similar to
Annex60.Fluid.Interfaces.StaticTwoPortConservationEquation
.I'll make a pull request.
The text was updated successfully, but these errors were encountered: