-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annex60.Fluid.Interfaces.FourPortHeatMassExchanger is not used #353
Comments
If All should comment whether this should be moved to the |
Is this related to #223 ?? |
#223 is much bigger as its main purpose is to model an actual heat pump, whereas the Carnot model is idealized and meant for applications where no data of the heat pump is available, e.g., it is solely based on thermodynamics 2nd law, plus an efficiency correction that optionally takes the load as an input. |
According to me, Annex60 could benefit of having the |
As discussed in lbl-srg/modelica-buildings/issues/471, I did the following changes: I also added the example from the building library and i've updated the reference result. I've pushed the changes on |
@damienpicard I will also correct the COP computation so that the useful heat is the heat of the evaporator for the chiller, and the heat of the condenser for the heat pump. To eliminate code duplication, I will refactor that |
The above models have been integrated and documented. The following still needs to be done:
|
This is to comply with the coding convention. For #353
@mwetter notice that |
Note from Corsica meeting: Michael to ensure that the model is used in a regression test in |
The model
Annex60.Fluid.Interfaces.FourPortHeatMassExchanger
is not used anywhere in the library, and hence it is also not part of any regression test.I suggest to keep the model in the library as it is similar to
TwoPortHeatMassExchanger
and libraries the are based onAnnex60
are using it, for example inBuildings.Fluid.Chillers.Carnot
.To avoid breaking the model, a regression test needs to be added.
The text was updated successfully, but these errors were encountered: