Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course regularisation in Annex60.BoundaryConditions.SolarIrradiation.BaseClasses.SkyClearness #521

Closed
Mathadon opened this issue Sep 22, 2016 · 1 comment · Fixed by #524

Comments

@Mathadon
Copy link
Member

I'm updating IDEAS to Annex60 models for solar irradiance computations. In our unit tests I detected a change in results for Annex60.BoundaryConditions.SolarIrradiation.BaseClasses.SkyClearness. More specifically the value of skyCle goes as low as 1 in our old implementation and now only as low as 1.1. This seems to be because of the regularisation.

skyCle =  smooth(1,
    if (HGloHor < Modelica.Constants.small)
      then 
        1
      else 
       IDEAS.Utilities.Math.Functions.smoothLimit(
        x = (HGloHor/IDEAS.Utilities.Math.Functions.smoothMax(
                       x1 = HDifHor,
                       x2 = 1e-4,
                       deltaX = 1e-5) + tmp1)/(1 + tmp1),
        l = 1,
        u = 8,
        deltaX = 0.1));

Since deltaX=0.1 the actual lower limit is 1.1 instead of 1. This has a non-negligible impact on our unit tests. Therefore I propose the change deltaX to 0.01 or lower.

@mwetter
Copy link
Contributor

mwetter commented Sep 24, 2016

@Mathadon This proposal is good. I will also change the regression test simulation period so that other values than the minimum sky clearness are computed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants