Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in valve models #558

Closed
Mathadon opened this issue Oct 26, 2016 · 1 comment
Closed

Bug in valve models #558

Mathadon opened this issue Oct 26, 2016 · 1 comment

Comments

@Mathadon
Copy link
Member

The current valve implementations do not guard against negative control signals. When the control signal becomes negative, the k value becomes negative, which causes the valve to behave like a pump.

This should be guarded against using an assert().
Mathadon added a commit that referenced this issue Oct 27, 2016
@Mathadon
added assert for phi>0 in valve partial
1c47217 
this is for #558
@Mathadon Mathadon mentioned this issue Oct 27, 2016
Merged
Mathadon added a commit that referenced this issue Nov 14, 2016
@Mathadon
addressed review comments in PartialTwoWayValve for #558
3bd1e30
@mwetter mwetter mentioned this issue Nov 16, 2016
Closed
@mwetter
Copy link
Contributor

mwetter commented Nov 22, 2016

This is on the master.

@mwetter mwetter closed this as completed Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mwetter @Mathadon