Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change validation test due to tool-dependent choice when using inStream operator #657

Closed
mwetter opened this issue Jan 18, 2017 · 1 comment · Fixed by #658
Closed

change validation test due to tool-dependent choice when using inStream operator #657

mwetter opened this issue Jan 18, 2017 · 1 comment · Fixed by #658
Assignees

Comments

@mwetter
Copy link
Contributor

mwetter commented Jan 18, 2017

There is a difference between JModelica and Dymola in the choice of eps for the inStream operator (see Modelica specification 3.3 p. 179) which affects the calculation for near zero or zero flows. In JModelica the smallest of the flow nominals is used as epsilon for all flows in the implementation whereas Dymola has specific epsilons for each of the flows.

This difference affects the verification of Annex60.Fluid.FixedResistances.Validation.FlowJunctionSteadyStateNoPressureDrop where the nominals for spl.res1.m_flow, spl.res2.m_flow, spl.res3.m_flow are not equal. To solve this issue, either:

  1. Remove the signals senTem1.T, senTem2.T and senTem3.T from the verification
  2. Adjust the nominal values so that spl.res1.m_flow, spl.res2.m_flow and spl.res3.m_flow have the same nominals
@mwetter mwetter self-assigned this Jan 18, 2017
mwetter added a commit that referenced this issue Jan 18, 2017
mwetter added a commit that referenced this issue Jan 18, 2017
mwetter added a commit that referenced this issue Jan 18, 2017
@Mathadon
Copy link
Member

How large is the difference in results due to this? It doesn't make sense to me to change models to get (more or less) exactly the same results in other tools, assuming the result difference is smaller than 1e-6 orso? I'll accept this pull request since the work has been done already :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants