Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idealSource does not simplify when allowFlowReversal = false #673

Closed
Mathadon opened this issue Mar 2, 2017 · 0 comments · Fixed by #677
Closed

idealSource does not simplify when allowFlowReversal = false #673

Mathadon opened this issue Mar 2, 2017 · 0 comments · Fixed by #677
Assignees

Comments

@Mathadon
Copy link
Member

Mathadon commented Mar 2, 2017

We currently have

  port_a.h_outflow = inStream(port_b.h_outflow);
  port_b.h_outflow = inStream(port_a.h_outflow);

which should probably become

  port_a.h_outflow = if allowFlowReversal then inStream(port_b.hi_outflow) else Medium.X_default[1:Medium.nXi];
  port_b.h_outflow = inStream(port_a.h_outflow);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant