Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should check zero m_flow_nominal in movers #908

Closed
Mathadon opened this issue Apr 14, 2018 · 2 comments · Fixed by #1075
Closed

should check zero m_flow_nominal in movers #908

Mathadon opened this issue Apr 14, 2018 · 2 comments · Fixed by #1075
Assignees

Comments

@Mathadon
Copy link
Member

I mistakenly tried to set a constant flow rate of 0 kg/s by setting m_flow_nominal in FlowControlled_m_flow instead of by setting constantMassFlowRate. This produces the following error

Model error - division by zero: (0.1*(pump1.eff.dpMax*pump1.eff.delta^2)) / (pump1.eff.V_flow_max) = (5) / (0)

It would be good to add an assert that verifies that m_flow_nominal is strictly positive?

@Mathadon Mathadon self-assigned this Apr 14, 2018
@Mathadon
Copy link
Member Author

@mwetter do you agree?

@mwetter
Copy link
Contributor

mwetter commented Apr 30, 2018

A check on m_flow_nominal > eps in the fan would be good.

Mathadon added a commit that referenced this issue Jan 8, 2019
added assert for m_flow_nominal in movers for #908
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants