Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples.CSVReader requires a pre-simulation that can break unit tests #983

Closed
mwetter opened this issue Jul 11, 2018 · 1 comment · Fixed by #984
Closed

Examples.CSVReader requires a pre-simulation that can break unit tests #983

mwetter opened this issue Jul 11, 2018 · 1 comment · Fixed by #984
Assignees
@mwetter

Comments

@mwetter
Copy link
Contributor

mwetter commented Jul 11, 2018

Examples.CSVReader requires first the simulation of Examples.CSVWriter for the csv file to exists. This will only work with Dymola but not with other tools that won't run the .mos script.
The csv file should be stored in a Data folder so that the library is portable across tools.
@mwetter mwetter self-assigned this Jul 11, 2018
mwetter added a commit that referenced this issue Jul 11, 2018
@mwetter
Refactored example for #983
1d34671
@mwetter mwetter mentioned this issue Jul 11, 2018
Merged
@Mathadon
Copy link
Member

I see the point, just too bad that we now do not automatically verify that the CSVWriter produces a file that can indeed be read by the CombiTimeTable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwetter mwetter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue983 csv writer ibpsa/modelica-ibpsa
2 participants
@mwetter @Mathadon